In general, it does look okay to me. Also, it's always good to first test a script before letting it out into the wild.

You must run it under an account that has aD amdin privileges. Also, change the code to:
code:
Break ON
; uncomment the next lien to step through the code
; DEBUG ON
; Example of LDAP call.  GetObject("LDAP://ou=Users,ou=YourBusinessUnit,dc=YourCompany,dc=com")
; You need to know your LDAP connection.  You can maybe find it by checking the propery details on the OU for your users.
$target = GetObject("LDAP://ou=Users,ou=Test,dc=sussexcounty,dc=net")
? 'Error = '+@ERROR+' - '+@SERROR
$loginscript="logon.bat"
For Each $user in $target
  If $user.loginscript <> $loginscript
    ? "Current Script for " +$user.name " is: " +$user.loginscript+ " Should be: " +$loginscript
;    $user.loginscript=$loginscript  ; Remove the semi-colon at the front of this line to enable actually resetting the logon bat. 
     ? 'Error = '+@ERROR+' - '+@SERROR
;    $user.SetInfo    ; Remove the semi-colon at the front of this line to enable actually resetting the logon bat. 
     ? 'Error = '+@ERROR+' - '+@SERROR
     ? "Changed current Script for " +$user.name " to: " +$user.loginscript
  EndIf
Next
to provide mote insight into what's happening.
_________________________
There are two types of vessels, submarines and targets.