Page 1 of 1 1
Topic Options
#362 - 1999-08-30 11:13 AM Script Suggestions Please
Anonymous
Unregistered


I have been working with KiXtart for about a month now and I have what I believe to be a good working script. Please take a look at it and tell me if I'm doing anything wrong or suggestions to make it run better.

RedirectOutput( "NUL",1 )
SetConsole( "minimize" )

settime \\fsxtlf10
use s: "\\fsvance10\NetShare"
use w: "\\dsvance10\WorldShare"
if @HOMESHR use h: @HOMESHR endif

if @RAS = 0

if @INWIN = 1 $OpSysInstalled=WindowsNT endif
if @INWIN = 2 $OpSysInstalled=Windows95 endif

if existkey( "HKEY_LOCAL_MACHINE\SOFTWARE\Vance Software" ) <> "0"
addkey( "HKEY_LOCAL_MACHINE\SOFTWARE\Vance Software" )
endif

if ingroup (@LSERVER + "\Non SMS Clients")=0 shell @LDRIVE + "\smsls.bat" endif
run "\\fsvance10\navadmin$\Nav32up.exe \\fsvance10\navadmin$\vance.nns"

if existkey( "HKEY_LOCAL_MACHINE\SOFTWARE\Vance Software\JetCopkg Installed" ) <> "0"
run "\\fsvance10\fixes$\office\jetcopkg.exe /q"
addkey( "HKEY_LOCAL_MACHINE\SOFTWARE\Vance Software\JetCopkg Installed" )
open (1,"\\fsvance10\pinfo$\jetcopkg_installed.csv",4)
writeline (1,"JetCopkg Installed,@WKSTA,@USERID,$OpSysInstalled,@DATE" + Chr(13) + Chr(10))
close (1)
endif

endif

exit

Top
#363 - 1999-08-30 01:12 PM Re: Script Suggestions Please
Anonymous
Unregistered


Jeff,
You might consider using documentation in your script for certain reasons. After you implement your script and come back to it several weeks later to update, you may forget what certain lines do what.
Also, if your script gets begger, it is a good idea to break subroutines down into individual kix scripts and call them from within the main script...
Hope this helps ya out.
ĄtranĄ

Top
Page 1 of 1 1


Moderator:  Jochen, Allen, Radimus, Glenn Barnas, ShaneEP, Ruud van Velsen, Arend_, Mart 
Hop to:
Shout Box

Who's Online
1 registered (Allen) and 1607 anonymous users online.
Newest Members
Viginette, ManuvdWielNL, Sir_Barrington, batdk82, StuTheCoder
17888 Registered Users

Generated in 0.117 seconds in which 0.084 seconds were spent on a total of 12 queries. Zlib compression enabled.

Search the board with:
superb Board Search
or try with google:
Google
Web kixtart.org