:COUNTER
$Que = $QUe +1
if $QUe="155"
goto END
else
$q = open(1,"c:\QUE.TXT",5)
$q = WRITELINE(1,"$QUe")
goto COUNTER

:END
endif
EXIT

------------------------------------
Basicly I want the script to count from 001
to 155, with an output like:
amappp001
amappp002
amappp003
through
amappp155
the script i have builds this
amappp1
amappp11
amappp111
amappp1111

as oyu can imagine in 20 seconds you get a file about 7MB in size with ALOT of 1'S.

How should I rethink my math functions?
Thanks in Advance!

------------------
THANKS
MARK =)

$Que = 1+$QUe

------------------
THANKS
MARK =)

code:

---

$n = 1
while $n < 156
select
   case len("$n") = 1
        $a = "apps00"
   case len("$n") = 2
        $a = "apps0"
   case len("$n") = 3
        $a = "apps"
endselect
   $x = "$a" + "$n"
   shell "%comspec% /c echo $x >> file.txt"
   $n = 1 + $n
loop

---

or this;

code:

---

? "Enter a number less than 155: " gets $n
$n = val("$n")
while $n < 156
select
   case len("$n") = 1
        $a = "apps00"
   case len("$n") = 2
        $a = "apps0"
   case len("$n") = 3
        $a = "apps"
endselect
   $x = "$a" + "$n"
   shell "%comspec% /c echo $x >> file.txt"
   $n = 1 + $n
loop
exit

---

------------------
BoxKite
FACTA NON VERBA

Forgot the exit in the top example

------------------
BoxKite
FACTA NON VERBA

code:

---

?" ENTER THE QUE IE. AMAPPP"
?""
GETS $QUe
$QUe = val("$QUe")
goto COUNTER
:COUNTER
$Que = $QUe + 1
if $QUe = 155
	goto END 
else
	$q = open(1,"c:\QUE.TXT",5)
	$q = WRITELINE(1,"$QUe")
	goto COUNTER
endif
	:END
EXIT

---

Bryce (glad to have the BB back! and not gald that my vacation is over )

• a lot of GOTO statements. code which is very hard to maintain.
  
• possible to get a deadlock situation, when you enter a number
  greater then 155. program never ends.
  
• each time you open the same file results in an enormous amount of
  registry calls, which isn't necessary.
  
• you don't check of file "c:\que.txt" was correct open.
  

• code:

  ---

  
  IF ....
     GOTO end
  ELSE
     :end
  ENDIF
  

  ---

  
  very original design. "GOTO end" statement not necessary. position of ":end" needs no explanation.
  
• using SELECT/ENDSELECT structure possible, but the same effect can be created by one single statement.
  
• usage of SHELL slows down performance, because each time a DOS virtual environment must be created.
  

Our version:

• an initialization block,
  
• a check of inconsistent settings,
  
• an input block,
  
• the real program with additional 'debug' code (= print statements).
  

code:

---

;
; - initialize variables -
;
$file="counter.txt"                  ; (I) ; filename
$prefix="amappp"                     ; (I) ; start of string
$suffix=""                           ; (I) ; end   of string
$format=5                            ; (I) ; max width of number range
$max_que=250                         ; (I) ; max          number of range
;
; - check variables -
;
IF ($max_que > substr("999999",1,$format)) ; correct of $max_que to max width of number range
  $max_que=substr("999999",1,$format)      ; position STOP  
ENDIF
;
? "Enter QUE ie."+LCASE($prefix)+" (max.value "+$max_que+") "
? 
GETS $que
;
$i=val("$que")                             ; position START
IF ($i <= $max_que)
  ? "Informative COUNT: start '$que' till '$max_que' on file '$file' ("+@time+")"
  ?
  IF (OPEN(1,$file,5) = 0)
    WHILE ($i <= $max_que)
      $info=$prefix+substr("000000",1,$format-len("$i"))+$i+$suffix+chr(13)+chr(10)
      IF (WriteLine(1,$info) <> 0)
        ? @serror
      ENDIF
      ? " "+substr("      ",1,$format-len("$i"))+$i+".."+$max_que+" -> "+LCASE($prefix+substr("000000",1,$format-len("$i"))+$i+$suffix)
      $i=$i+1
    LOOP
    IF Close(1) <> 0
    ENDIF
  ENDIF
  ?
  ? "Informative COUNT: ("+$que+".."+$max_que+") completed. ("+@time+")"
ELSE
  ? "Abort COUNT: out of range"
ENDIF
EXIT

---

Example of output after entering value '3':

code:

---

Enter QUE ie.amappp (max.value 250)
Informative COUNT: start '3' till '250' on file 'counter.txt' (05:15:16)
     3..250 -> amappp00003
     4..250 -> amappp00004
     5..250 -> amappp00005
     6..250 -> amappp00006
     7..250 -> amappp00007
     8..250 -> amappp00008
     9..250 -> amappp00009
    10..250 -> amappp00010
            ...
   240..250 -> amappp00240
   241..250 -> amappp00241
   242..250 -> amappp00242
   243..250 -> amappp00243
   244..250 -> amappp00244
   245..250 -> amappp00245
   246..250 -> amappp00246
   247..250 -> amappp00247
   248..250 -> amappp00248
   249..250 -> amappp00249
   250..250 -> amappp00250
Informative COUNT: (3..250) completed. (05:15:24)

---

Another run after changing variables of initialization block.

code:

---

$file="counter.txt"                  ; (I) ; filename
$prefix="Count-"                     ; (I) ; start of string
$suffix=".txt"                       ; (I) ; end   of string
$format=4                            ; (I) ; max width of number range
$max_que=250                         ; (I) ; max          number of range

---

Example of output after entering value '235':

code:

---

Enter QUE ie.count- (max.value 250) 
Informative COUNT: start '235' till '250' on file 'counter.txt' (05:18:26)
  235..250 -> count-0235.txt
  236..250 -> count-0236.txt
  237..250 -> count-0237.txt
  238..250 -> count-0238.txt
  239..250 -> count-0239.txt
  240..250 -> count-0240.txt
  241..250 -> count-0241.txt
  242..250 -> count-0242.txt
  243..250 -> count-0243.txt
  244..250 -> count-0244.txt
  245..250 -> count-0245.txt
  246..250 -> count-0246.txt
  247..250 -> count-0247.txt
  248..250 -> count-0248.txt
  249..250 -> count-0249.txt
  250..250 -> count-0250.txt
Informative COUNT: (235..250) completed. (05:18:27)

---

Same source without a great amount of comment statements.
Manipulation will be harder.

code:

---

$file="counter.txt"                  ; (I) ; filename
$prefix="Count-"                     ; (I) ; start of string
$suffix=".txt"                       ; (I) ; end   of string
$format=4                            ; (I) ; max width of number range
$max_que=250                         ; (I) ; max          number of range/position STOP
;
IF ($max_que > substr("999999",1,$format))
  $max_que=substr("999999",1,$format)     
ENDIF
? "Enter QUE ie."+LCASE($prefix)+" (max.value "+$max_que+") "
? 
GETS $que
;
$i=val("$que")                             ; position START
IF ($i <= $max_que)
  IF (OPEN(1,$file,5) = 0)
    WHILE ($i <= $max_que)
      $info=$prefix+substr("000000",1,$format-len("$i"))+$i+$suffix+chr(13)+chr(10)
      IF (WriteLine(1,$info) <> 0)
      ENDIF
      $i=$i+1
    LOOP
    IF Close(1) <> 0
    ENDIF
  ENDIF
ENDIF
EXIT

---

Same source without any comment and without any structure.
Manipulation will be harder.

code:

---

$file="counter.txt" $prefix="Count-" $suffix=".txt" $format=4 $max_que=250 IF ($max_que > substr("999999",1,$format)) $max_que=substr("999999",1,$format) ENDIF ? "Enter QUE ie."+LCASE($prefix)+" (max.value "+$max_que+") " ? GETS $que $i=val("$que") IF ($i <= $max_que) IF (OPEN(1,$file,5) = 0) WHILE ($i <= $max_que) $info=$prefix+substr("000000",1,$format-len("$i"))+$i+$suffix+chr(13)+chr(10) IF (WriteLine(1,$info) <> 0) ENDIF $i=$i+1 LOOP IF Close(1) <> 0 ENDIF ENDIF ENDIF EXIT 

---

The most interesting part for me was the way of convertion of strings to numbers.
Greetings.

• an endless loop
  
• an automatic reboot
  
• a DrWatson error
  

BTW: a simple script is when it is one line. see last piece of code. Mark's didn't ask for something which isn't possible to maintain.
A new version we can run is:

code:

---

begin.
¶ìš–锡ê깿ôýÑ…–µ˜Úä¾™€’�Â÷‹²ã�ß·ÝñŠé¸âùéç̌–ÎË‘õà®ÔæҴ臑ᓰ<
׎·›•éšë¿‰ØêïÂŒï†éˆÓÎ髸•â�Š¦¿Ý�÷¡ûô€í„åÙɧøÑŒÖ÷�Þ÷¤­“žÊŸé‚Ī‹<
è૵ˆ±‹Èøí£ÿ—ðÝ›àýäþ£�©ÜØ¡åÜÊÙ˜å¿Õ帑śꮣ“òâ˜�Ç£„¿ÉÏÕø¿ðÖÈÓ‰’<
·¼ýõÐù˜¯òæ÷–¡Á€¸ÿç›Â΋´Ìû¼’ôƒÕ½ƒãÏÌ’€¸å¼¬•õšÐê¹È‚í¿Ý™îнÇÕŒ´�<
”÷§ÀéÏÎâÔ—ƒøé�§¦¯×úõôó;’®ñâÓÿ䯔À�‹î„Š•ŸŒÏŒÆ�ØóÿÀ¦‹ø³‘à†ÃÂ�¹½<
Å”Œ¡™¦�š¡ö”£ýâÐҫ于×ÞÕÙŒŸ²Ä´Š¾¤‹–¡Á­ùÖññÕåûÎ…ÑœéŽì¾¯ßä·¨­�•Î®<
¹ÅïÆÿ�„ºž‰ªêŠ¿Å°Ýñ‹ÙÉŸõžŒÅ�Õ”·¶ý•Ü•µ”<
end: completed.

---

• it isn't readable.
  
• can not be changed.
  
• you can protect is to run on other servers and workstations.
  

More information about this kind of kixtart manipulation at
http://kixtart.org/board/Forum2/HTML/000392.html

[This message has been edited by MCA (edited 16 June 2000).]

[This message has been edited by MCA (edited 16 June 2000).]

[This message has been edited by MCA (edited 16 June 2000).]

Mark, are You Happy ???

_________________________