I agree. This eliminates the need to edit the script to add further groups.

 Code:
$mac = GetBSSID(1,@WkSta)
$location = ReadProfileString ($LogonServer+"\NETLOGON\printer.ini", $mac, "Location")
$groups = ReadProfileString ($LogonServer+"\NETLOGON\printer.ini", $mac, "Groups")
$groups = Split($groups,",")

For Each $group in $groups
   If InGroup($group)
      $shares = ReadProfileString ($LogonServer+"\NETLOGON\printer.ini", $mac+":"+$group, "Shares")
      $shares = Split($shares,",")
      $sharenum = 0
      For Each $shareobj in $shares
         $name = Split($shareobj,":")[0]
         $share = Split($shareobj,":")[1]
         If AddPrinterConnection("\\server\"+$share) = 0
            If $sharenum = UBound($shares)
               $null = SetDefaultPrinter("\\server\"+$name)
            EndIf
         Else
            $null = MessageBox("2 Der er et problem med at etablerer forbindelse til : "+$share,"Printer fejl",0)
         EndIf
         $sharenum = $sharenum+1
      Next
   EndIf
Next


 Code:
[00:25:9C:AD:43:D6]
Location = Preparation
Groups = Student,Teacher,Admin

[00:25:9C:AD:43:D6:Teacher]
Shares = HP LaserJet 1320nw - Support:LaserJet1,Xerox WorkCentre 7345:Xerox1

[00:25:9C:AD:43:D6:Student]
Shares = HP LaserJet 1320nw - Support:LaserJet1

[00:25:9C:AD:43:D6:Admin]
Shares = HP LaserJet 1320nw - Support:LaserJet1,Xerox WorkCentre 7345:Xerox1,Other Admin Printer:Admin1