Oke, rewritten your code in your fisrt post.

First of all i removed all the gosub's and labels. I dont like them all that much
Taken all the variables and/or kix macro's outside the quotes, dont put them inside quotes
You could also use a select - case - endselect statement instead of the if - else - endif's or use a map drive UDF instead of the use somedrive: \\server\share stuff.
If everything works ok I would remove some error checking to make it a bit moer readable.

This code should do the trick:

Code:

If InGroup("Windows Group 1")
;remove all drive mappings
Use * / delete
If @ERROR <> 0
? "Recieved Error("+ @error + ") when disconnecting all drives."
Else
?"Successfully removed all drive mappings."
EndIf
;map U: drive to users folder
Use U: "\\server\share\" + @USERID
If @ERROR <> 0
? "Recieved Error(" + @error + ") when connecting drive U: to \\server\share\." + @USERID
Else
?"Successfully mapped drive U: to \\server\share\" + @USERID
EndIf
;map F: drive to some folder
Use F: "\\server\share"
If @ERROR <> 0
? "Recieved Error(" + @error + ") when connecting drive F: to \\server\share."
Else
?"Successfully mapped drive F: to \\server\share."
EndIf
EndIf

If InGroup("Windows Group 2")
;remove all drive mappings
Use * / delete
If @ERROR <> 0
? "Recieved Error(" + @error + ") when disconnecting all drives."
Else
?"Successfully removed all drive mappings."
EndIf
;map U: drive to users folder
Use U: "\\server\share\" + @USERID
If @ERROR <> 0
? "Recieved Error(" + @error + ") when connecting drive U: to \\server\share\." + @USERID
Else
?"Successfully mapped drive U: to \\server\share\" + @USERID
EndIf
;map H: drive to some folder
Use G: "\\server\share"
If @ERROR <> 0
? "Recieved Error(" + @error + ") when connecting drive G: to \\server\share."
Else
?"Successfully mapped drive G: to \\server\share."
EndIf
EndIf

If InGroup("Windows Group 3")
;remove all drive mappings
Use * / delete
If @ERROR <> 0
? "Recieved Error(" + @error + ") when disconnecting all drives."
Else
?"Successfully removed all drive mappings."
EndIf
;map U: drive to users folder
Use U: "\\server\share\" + @USERID
If @ERROR <> 0
? "Recieved Error(" + @error + ") when connecting drive U: to \\server\share\." + @USERID
Else
?"Successfully mapped drive U: to \\server\share\" + @USERID
EndIf
;map H: drive to some folder
Use H: "\\server\share"
If @ERROR <> 0
? "Recieved Error(" + @error + ") when connecting drive H: to \\server\share."
Else
?"Successfully mapped drive H: to \\server\share."
EndIf
EndIf



[edit]
damn those typo's
[/edit]


Edited by R2D2 (2005-01-25 10:34 PM)
_________________________
Mart

- Chuck Norris once sold ebay to ebay on ebay.