function MapPrinter("\\2003 server\printer01",1,"\\NTserver\hp4000") function MapPrinter("\\2003 server\printer02",1,"\\NTserver\hp3500") function MapPrinter("\\2003 server\printer03",1,"\\NTserver\hplaser") function MapPrinter("\\2003 server\printer04",1,"\\NTserver\konminpcl") function MapPrinter("\\2003 server\printer05",1,"\\NTserver\konminps") function MapPrinter("\\2003 server\printer06",1,"\\NTserver\hp200") DIM $index,$IsInstalled,$lptprinter,$inst_printers,$PrinterPorts,$port_type $index=0 $IsInstalled=0 $lptprinter=0 $PrinterPorts="HKEY_CURRENT_USER\Software\Microsoft\Windows NT\CurrentVersion\PrinterPorts" if $oldspool $=DelPrinterConnection($oldspool) endif :loopprinters $inst_printers=enumvalue($PrinterPorts,$index) if @error=0 $port_type=readvalue("$PrinterPorts","$inst_printers") if $printer=$inst_printers $IsInstalled=1 endif if instr("$port_type","LPT") $lptprinter=1 endif $index=$index+1 goto loopprinters endif if $IsInstalled=0 $=AddPrinterConnection("$printer") endif if $IsInstalled=0 and $lptprinter=0 and $default $=SetDefaultPrinter("$printer") endif endfunction

First off, you don't use "FUNCTION" more than once. The FUNCTION function is used to define a new function - once it's defined, you reference it like any other built-in command. You would insert the MapPrinter code to either the very beginning or very end (my preference) of your script, without any changes. Kix will locate any Function definitions first, so they are available to your script logic.

I suggested that you utilize the logic of the mapprinter to decide what to do. Here's a few more thoughts..

Create a PRINTERS.INI file that looks like this:

Code:

[PRINTERS]
NewPrint1=OldPrint1
NewPrint2=OldPrint2
NewPrint3=0

This provides a list of every new printer name, and the corresponding printer it replaced. If it is an additional printer and did not replace one, just set the old printer name to zero.

You can now easily get a list of the new printers by using the ReadProfileString function. Enumerate the list and get the names of the old printers for each new one. If the old name is zero ("0"), then there is no old printer to worry about.

Code:

$NewPrint = ReadProfileString(@SCRIPTDIR + 'printers.ini', 'PRINTERS')
For Each $Printer in $NewPrint
  $OldPrint = ReadProfileString(@SCRIPTDIR + 'printers.ini', 'PRINTERS', $Printer)
  'Processing ' $Printer   ; identify current printer
  If $OldPrint = 0
    ' - adding new!' ?     ; no old printer
    ; Just map the new printer
  Else
    ' - removing ' $OldPrint ? ; removing old printer
    ; see if $OldPrint is defined, if it is, use MapPrinter() to
    ; remove the old and define the new, otherwise, simply add
    ; the new printer connection. You might want to modify MapPrinter
    ; to check for the printer, and map only if the old printer is defined
    ; or - put the decision logic here - addprinterconnection() if 
    ; $OldPrint is 0 else MapPrinter(new,1,old)
    ;
    ; insert your preferred logic here...
    ;
  EndIf
  '  ' @SERROR ? ?     ;  indent result message and skip extra line
Next

Start small - just list a few printers in your INI file for testing. During testing, don't call the functions, print messages telling you what the code would do.. when it seems like the logic is correct, fill in the remaining printers in the INI file and uncomment the lines that do the actual work.

Glenn

select case PriMapState("\\OldPrintServer\Printer1") = 1 MapPrinter("\\NewPrintServer\PrinterX",,"\\OldPrintServer\Printer1") case PriMapState("\\OldPrintServer\Printer1") = 2 MapPrinter("\\NewPrintServer\PrinterX",1,"\\OldPrintServer\Printer1") endselect